Implement reading all wasm module roots in machine locator [NIT-2444] #2254
Conversation
cla-bot
bot
added
the
s
anodar
changed the title
| moduleRoots[moduleRoot] = true | ||
| if file.Name() == "latest" { | ||
| latestModuleRoot = moduleRoot | ||
| rootPath = dir | ||
| } |
There was a problem hiding this comment.
Only include dirs if their name is either "latest" or the wasmMduleRoot - otherwise locator will not be able to find it
see GetMachinePath.
There was a problem hiding this comment.
Isn't that exactly what I'm doing already ? Iterating all folders, checking if there's module-root.txt then reading file content (which is same as directory name if it's not "latest"), then adding to moduleRoots.
Or am I missing something ?
There was a problem hiding this comment.
if you have a file "foobar/module-root.txt" - you cannot use this module-root because the locator won't be able to find "foobar" dir later. We can change that in GetMachinePath.. but easier to just not include it in the list.
| moduleRoots[moduleRoot] = true | ||
| if file.Name() == "latest" { | ||
| latestModuleRoot = moduleRoot | ||
| rootPath = dir |
There was a problem hiding this comment.
rootpath=dir doesn't belong in the latest "if". machines might not have a "latest" and it'd still be correct
No description provided.